feat(radio, radio-group): Enhance accessibility with arrow key navigation and aria attributes #951
+71
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… close buttons and progress indicator
…ion and aria attributes
mryunt02
changed the title
|
this PR fails the test but I think it is necessary, I did not change the test file to avoid breaking it. |
erbilnas
reviewed
Oct 30, 2024
| @@ -19,7 +19,7 @@ describe("bl-radio", () => { | |||
| `<div | |||
| aria-disabled="false" | |||
| aria-labelledby="label" | |||
| aria-readonly="false" | |||
There was a problem hiding this comment.
I don’t quite understand why you did this
There was a problem hiding this comment.
aria-readonly property is not supported in Radio Group according to W3C ARIA Radio Group Example
Enes5519
requested changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and resolves issue #950.
Changes Made:
aria-readonlyproperty from the Radio Button component.aria-checkedattribute to the Radio Button component to indicate its checked state.These changes improve the accessibility and user experience of the Radio Group component in compliance with W3C ARIA Radio Group Example.
This PR resolves issue #950.